Added headers parameter which can be used to pass custom headers#10
Merged
gagantrivedi merged 7 commits intoFlagsmith:mainfrom Oct 12, 2021
Merged
Conversation
… API calls made to flagsmith
matthewelwell
requested changes
Sep 28, 2021
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @nogoodusername, I've added a few comments where we can improve this. It's also highlighted some other areas of the code that can be improved so I can tidy those up in a separate PR after we get this one merged.
matthewelwell
requested changes
Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a header parameter to flagsmith. Accepts a dictionary.
We're planning to run flagsmith behind a gateway and the gateway will prevent unauthorised identity / trait manipulation will happen via clients.